Comments on: Why That Batch For Loop Isn’t Working

By: HS

HS — Wed, 26 Oct 2011 21:23:26 +0000

Thanks! It helped me to find out that the variable that depends on the parameter of the for loop has to be written within between two ‘!’

By: Neal Rosen

Neal Rosen — Sun, 02 Oct 2011 21:05:35 +0000

Hi All,

ok so just curious…

This does not work:
:: Hi There
@echo off
for /L %%a IN (1,1,10) do (
echo hi there
:: COMMENT
)

exit /b

But this DOES:

:: Hi There
@echo off
for /L %%a IN (1,1,10) do (
echo hi there
REM COMMENT
)

exit /b

POR QWA???

Cheerz,

Neal

By: Vikas

Vikas — Thu, 04 Aug 2011 14:51:28 +0000

This is really useful. I was searching for this exactly. Many thanks !!

By: Eric

Eric — Thu, 28 Jul 2011 19:02:13 +0000

Wow! I was banging myself until I found your solution. Thanks Dude!!

By: David

David — Sun, 03 Jul 2011 13:33:50 +0000

Thank you very much! This is very helpful!

By: Hermund

Hermund — Wed, 27 Apr 2011 15:50:28 +0000

I was banging my head in the wall until I found this article.

Thank you very much!

By: GibStorm

GibStorm — Thu, 27 Jan 2011 12:40:00 +0000

I’ve been struggling with this problem what seems like forever. I cannot tell you how greatful I am! A million thanks.

By: painfree

painfree — Thu, 04 Nov 2010 10:57:26 +0000

Wow! That was exactly what I was looking for. This was driving me mad. Excellent work.

By: A CMD Script Reads from a File -------- Some Notes in Microsoft

A CMD Script Reads from a File -------- Some Notes in Microsoft — Fri, 01 Oct 2010 13:55:27 +0000

[...] has really munged the MSI.There is one exception to the above, gratefully found reported here:http://blog.crankybit.com/why-that-batch-for-loop-isnt-working/It occurs when there is a separate variable to be set inside the FOR loop. In these cases, one [...]

By: sAtancik

sAtancik — Thu, 12 Aug 2010 09:14:52 +0000

Works flawlessly! You saved my day. Many thanks Josh!

By: Herbie

Herbie — Wed, 28 Jul 2010 09:25:24 +0000

Brilliant. Worked first time. No fuss. Many thanks.

By: mike

mike — Mon, 28 Jun 2010 20:53:03 +0000

Works, thank you Josh!

By: dataman

dataman — Tue, 27 Apr 2010 10:04:01 +0000

Great tip.

Just ran into this problem. Thanks for the solution.

Some one asked how to increment variable value, I know it’s late, but here it is anyways.

SET VAR1=A, B, C, D
SET count=0
FOR %%j IN (%VAR1%) DO (
SET /A count+=1
ECHO !count! – %%j
)

ECHO %count%

By: runescape hack

runescape hack — Sat, 17 Apr 2010 15:31:32 +0000

@jake iam not sure thats really right grtz runescape hack

By: Ketan

Ketan — Sat, 12 Sep 2009 15:26:05 +0000

Thanks Joshua ,
I started working on a batch script and was literally going mad with this for last 2 hrs.

Thanks again

By: PhilH

PhilH — Thu, 13 Aug 2009 16:31:23 +0000

hmm, not quite what I wanted
I want to increment a count variable within the loop
but that doesn’t work
is there another setlocal variable for this?
found it , variable has to be in ! eg !var!

By: PhilH

PhilH — Wed, 12 Aug 2009 18:27:10 +0000

hmm, not quite what I wanted
I want to increment a count variable within the loop
but that doesn’t work
is there another setlocal variable for this?

By: PhilH

PhilH — Wed, 12 Aug 2009 18:01:56 +0000

great stuff ,
I struggled for 2 days before finding this

By: Beakie Hill

Beakie Hill — Mon, 27 Jul 2009 04:27:15 +0000

This post is solid gold! If I’d happened across it first I would have saved 3 days of frustration following other tips that didn’t pan out. The great thing about this one is it’s specific from first to last and doesn’t leave open syntax issues. Perfect for a learner like me. Ironic that Josh is almost apologetic about giving the routine something to do! Thank you, Josh

By: Kerlutin

Kerlutin — Fri, 29 Aug 2008 15:49:29 +0000

Awesome! Thanks!